Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
74bf704 to
659f3d2
Compare
dhtclk
left a comment
There was a problem hiding this comment.
Just a few minor nits on voice and grammar, as well as the use of the note admonition.
docs/integrations/data-ingestion/etl-tools/fivetran/reference.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/etl-tools/fivetran/troubleshooting.md
Outdated
Show resolved
Hide resolved
|
Thanks for all these suggested changes @dhtclk 🙇 |
docs/integrations/data-ingestion/etl-tools/fivetran/reference.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/etl-tools/fivetran/reference.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/etl-tools/fivetran/reference.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/etl-tools/fivetran/reference.md
Outdated
Show resolved
Hide resolved
BentsiLeviav
left a comment
There was a problem hiding this comment.
Left a few comments/questions.
In addition, can we go over the code and track errors we raise, and document them with an explanation in the troubleshooting guide? (if they are not here already)
docs/integrations/data-ingestion/etl-tools/fivetran/reference.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/etl-tools/fivetran/troubleshooting.md
Outdated
Show resolved
Hide resolved
f26cdbb to
a048bdc
Compare
|
@BentsiLeviav I have checked the errors sent by the server and I feel most of them should not be documented, but I have included in the Troubleshooting section a few ones. Included:
Not included:
For future reference in case of needed: this is the full .md generated by Claude for all the errors mentioned: error-reference.md |
docs/integrations/data-ingestion/etl-tools/fivetran/reference.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/etl-tools/fivetran/troubleshooting.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/etl-tools/fivetran/troubleshooting.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
…oting.md Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
…re as it's internally managed.
…created in History mode
a952d15 to
49b7eae
Compare
Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
…oting.md Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
…oting.md Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
|
Thanks again for checking it, @dhtclk! I appreciate your willingness to unlock the PR, but I'd like to wait for full approval from @BentsiLeviav just to confirm that the content is aligned with expectations. |
Revamp Fivetran docs:
Indexcover more details about the current version and related filesReferencecovers all the docs we have in Fivetran side: configurations, table engine details...setup-guide, only the configurations details. The full guide should be kept complete in Fivetran side as it's really nice to have it when editing the connector.Troubleshootingcontains usual errors with possible solutions, good practices and some examples to help debugging.